[asterisk-dev] [Code Review] chan_sip consumption test for named ACLs

jrose reviewboard at asterisk.org
Tue Jul 17 14:06:17 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2045/
-----------------------------------------------------------

(Updated July 17, 2012, 2:06 p.m.)


Review request for Asterisk Developers, Mark Michelson, opticron, and Matt Jordan.


Changes
-------

Puts sqlite3 database path stuff in main()


Summary
-------

Tests calls made with SIP peers using different addresses against different ACLs.  Includes tests for the following:

1. Single ACL set via permit/deny
2. Single ACL set via acl=named_acl
3. Multiple ACLs set via acl=named_acl1,named_acl2,...
4. A bad ACL set via acl=<unavailable ACL name>
5. Multiple ACLs set from a realtime SQLite3 db via acl=realtime1,realtime2,...


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/realtime.sqlite3 UNKNOWN 
  /asterisk/trunk/tests/channels/SIP/acl_call/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 3311 
  /asterisk/trunk/tests/channels/SIP/acl_call/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/extconfig.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/modules.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/res_config_sqlite3.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/acl_call/configs/ast1/acl.conf PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2045/diff


Testing
-------

1. Ran the test itself and made sure the expected log messages appeared
2. Changed some test expectations to see how it would handle results differing from expectations.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/5061c47b/attachment.htm>


More information about the asterisk-dev mailing list