[asterisk-dev] [Code Review] Separate SIP registration and subscription expiry timer values

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2051/#review6695
-----------------------------------------------------------

Ship it!


Good work!

- Mark


On July 17, 2012, 9:06 a.m., Guenther Kelleter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2051/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 9:06 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Add options subminexpiry and submaxexpiry in sip.conf to set limits of subscription timer independently from registration timer settings. The setting of the registration timer limits still is done by options minexpiry, maxexpiry and defaultexpiry. For backwards compatibility the setting of minexpiry and maxexpiry also is used to configure the subscription timer limits if subminexpiry and submaxexpiry are not set in sip.conf.
> 
> Bug fixed: Set registration timer limits to default values when reloading sip configuration and values are not set by configuration.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 370151 
>   /trunk/channels/chan_sip.c 370151 
>   /trunk/configs/sip.conf.sample 370151 
> 
> Diff: https://reviewboard.asterisk.org/r/2051/diff
> 
> 
> Testing
> -------
> 
> Registration and subscription checked (sip set debug).
> 
> 
> Thanks,
> 
> Guenther
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/2a400d65/attachment-0001.htm>