[asterisk-dev] [Code Review]: Revise skinny debugging messages

[wedhorn]

> On July 13, 2012, 11:38 a.m., opticron wrote:
> > It appears that SKINNY_DEBUG is only used for ast_verb calls.  Consider refactoring to fit that case.

Not sure how this would be refactored given the unknown number of arguments being supplied to ast_verb.


> On July 13, 2012, 11:38 a.m., opticron wrote:
> > trunk/channels/chan_skinny.c, line 3419
> > <https://reviewboard.asterisk.org/r/2040/diff/1/?file=30201#file30201line3419>
> >
> >     Might as well use += for ptr in all these cases.

Done.


> On July 13, 2012, 11:38 a.m., opticron wrote:
> > trunk/channels/chan_skinny.c, line 4909
> > <https://reviewboard.asterisk.org/r/2040/diff/1/?file=30201#file30201line4909>
> >
> >     The ternary operator should be used in the form "condition ? true : false" (note the spaces around the operators). This should be fixed in all additions and modifications. It should be easy enough to just edit this in the diff and then reapply it.

Done. Think I got them all.


- wedhorn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2040/#review6681
-----------------------------------------------------------


On July 12, 2012, 4:41 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2040/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 4:41 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Rewrite of skinny debugging.
> 
> Debugging messages and associated controls only compiled in if configured with --enable-dev-mode
> 
> Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.
> 
> Functionally no real change to chan_skinny.
> 
> While the diff is fairly large, there are basically 3 components,
>  - definition of SKINNY_DEBUG at lines 134-152
>  - control functions at lines 3238-3374
>  - numerous uses of SKINNY_DEBUG throughout
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 369749 
> 
> Diff: https://reviewboard.asterisk.org/r/2040/diff
> 
> 
> Testing
> -------
> 
> Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/c3c5f842/attachment-0001.htm>