[asterisk-dev] [Code Review] code cleanup of sip.conf outboundproxy parsing

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2034/#review6686
-----------------------------------------------------------

Ship it!


This looks good to me! You did a great job of making sure that the code works with both the statically allocated proxy and ao2-allocated proxies.


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2034/#comment12700>

    There's a red blob here.


- Mark


On July 12, 2012, 2:19 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2034/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 2:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Normally I'd put this in trunk, but it does contain an actual bugfix:
> 
> 
> Index: channels/chan_sip.c
> ===================================================================
> --- channels/chan_sip.c	(revision 369992)
> +++ channels/chan_sip.c	(working copy)
> @@ -27607,7 +27607,7 @@
>  
>  				if (ast_strlen_zero(proxyname)) {
>  					ast_log(LOG_WARNING, "you must specify a name for the outboundproxy on line %d of sip.conf\n", v->lineno);
> -					sip_cfg.outboundproxy.name[0] = '\0';
> +					peer->outboundproxy->name[0] = '\0';
>  					continue;
>  				}
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 369992 
> 
> Diff: https://reviewboard.asterisk.org/r/2034/diff
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120713/190bf6e5/attachment-0001.htm>