[asterisk-dev] [Code Review] Prevent duplicate ICE candidates and per-peer ICE disabling

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2044/#review6683
-----------------------------------------------------------


This looks good to go.  The only concern I have is that "icesupport" is used in rtp.conf and "disable_ice" is used in sip.conf when they share very similar functionality (differing only in scope from a user perspective).

- opticron


On July 13, 2012, 7:58 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2044/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 7:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch prevents multiple ICE candidates with the same details from being produced and also allows ICE to be disabled on a per-peer basis for situations where it will just not be useful to have it.
> 
> 
> This addresses bug ASTERISK-20088.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20088
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 369935 
>   /trunk/channels/sip/include/sip.h 369935 
>   /trunk/configs/sip.conf.sample 369935 
>   /trunk/res/res_rtp_asterisk.c 369935 
> 
> Diff: https://reviewboard.asterisk.org/r/2044/diff
> 
> 
> Testing
> -------
> 
> Changed code to add multiple candidates with same details, confirmed only one is added.
> Disabled ICE on a specific peer, confirmed disabled.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120713/dff539b3/attachment.htm>