[asterisk-dev] [Code Review] Convert app_confbridge to use the new config options API

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2024/
-----------------------------------------------------------

(Updated July 12, 2012, 5:28 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address mmichelson's review and update to work with latest ACO change.


Summary
-------

This converts the confbridge app to use the new ACO API. A couple of small additions were added to the ACO API to accomodate app_confbridge:
1) A default handler was added for storing options in character arrays of a given length
2) A NoOp default handler was added so that that type= fields that are used for matching a specific type can be ignored and not cause a parsing failure
3) The aco_process_var() function was added to allow processing an individual option/value and applying it to an object. app_confbridge uses this to create user/bridge profiles with the CONFBRIDGE dialplan function.

The only behavior change that I am aware of is that the announce_only_user option (which defaulted to "yes" and used ast_true() with negative logic to clear the USER_OPT_NOONLYPERSON flag) now defaults to "yes" and evaluates using ast_false(). So basically "true" used to be default or ast_true(var->value). Now it is default or !ast_false(var->value) which is more in keeping with "yes" being the default anyway.


Diffs (updated)
-----

  /trunk/apps/confbridge/conf_config_parser.c 370043 
  /trunk/apps/confbridge/include/confbridge.h 370043 
  /trunk/include/asterisk/config_options.h 370043 
  /trunk/main/config_options.c 370043 

Diff: https://reviewboard.asterisk.org/r/2024/diff


Testing
-------

Created several users/bridges and verified that settings looked right with the CLI confbridge show profile/menu commands. Ran dialplan with some CONFBRIDGE() calls to verify that settings changed appropriately and that templates appeared to work.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120712/2596fbef/attachment.htm>