[asterisk-dev] [Code Review] SDP Media Attribute Test

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2029/
-----------------------------------------------------------

(Updated July 10, 2012, 2:30 p.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporated feedback and added test to ensure attributes are not just copied and sent willy nilly for any codec.


Summary
-------

This test ensures that attribute information is transported through Asterisk.


Diffs (updated)
-----

  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h263.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h264.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_speex.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h263.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h264.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_speex.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 3307 

Diff: https://reviewboard.asterisk.org/r/2029/diff


Testing
-------

Ran it, checked to make sure it worked okay. Tweaked test to fail and made sure it failed as expected.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120710/6c40ce5c/attachment.htm>