[asterisk-dev] [Code Review] SDP Media Attribute Test

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2029/#review6648
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/2029/#comment12629>

    remove



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/2029/#comment12628>

    udpbindaddr=127.0.0.1



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test
<https://reviewboard.asterisk.org/r/2029/#comment12632>

    I believe you should be checking test.passed(), something about the TestRunner class.
    
    To be honest, I might be wrong since I have not tested out the new stuff.



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h263.xml
<https://reviewboard.asterisk.org/r/2029/#comment12626>

    IIRC, hard tabs break some versions of SIPp and had to convert them to spaces.



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h264.xml
<https://reviewboard.asterisk.org/r/2029/#comment12627>

    same



/asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml
<https://reviewboard.asterisk.org/r/2029/#comment12630>

    11.0.0?


- Paul


On July 10, 2012, 2:01 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2029/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 2:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that attribute information is transported through Asterisk.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3307 
> 
> Diff: https://reviewboard.asterisk.org/r/2029/diff
> 
> 
> Testing
> -------
> 
> Ran it, checked to make sure it worked okay. Tweaked test to fail and made sure it failed as expected.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120710/b2aa6c10/attachment-0001.htm>