[asterisk-dev] [svn-commits] jrose: branch 1.8 r369750 - /branches/1.8/channels/chan_sip.c

[Olle E. Johansson]

6 jul 2012 kl. 22:54 skrev SVN commits to the Digium repositories:

> Author: jrose
> Date: Fri Jul  6 15:54:04 2012
> New Revision: 369750
> 
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=369750
> Log:
> chan_sip: Add case for FLASH control frames so that we don't display a warning.
> 
> chan_sip channels can receive flash control frames when connected to analog
> phones and possibly for other reasons. There really isn't a reason to warn when
> these frames are received, we can safely ignore them.
> 
> Patches:
>    dahdi_sip_flash.diff uploaded by Jonathan Rose (license 6182)
> 
> Modified:
>    branches/1.8/channels/chan_sip.c
> 
> Modified: branches/1.8/channels/chan_sip.c
> URL: http://svnview.digium.com/svn/asterisk/branches/1.8/channels/chan_sip.c?view=diff&rev=369750&r1=369749&r2=369750
> ==============================================================================
> --- branches/1.8/channels/chan_sip.c (original)
> +++ branches/1.8/channels/chan_sip.c Fri Jul  6 15:54:04 2012
> @@ -7006,6 +7006,8 @@
> 		break;
> 	case AST_CONTROL_UPDATE_RTP_PEER: /* Absorb this since it is handled by the bridge */
> 		break;
> +	case AST_CONTROL_FLASH: /* Absorb this since it is irrelevant to SIP. */
> +		break;

The should be sent down the RTP stack and be sent as RFC 2833 signals. We do already receive them,
so why not send them?

/O