[asterisk-dev] [Code Review] Predial testsuite test.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2006/#review6615
-----------------------------------------------------------



/asterisk/trunk/tests/predial/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/2006/#comment12567>

    You may run into timing dependent problems since this is waiting on a menu option to be played back.  If so, you'll need to use TestEvents (which would already be fired if this is using file.c's / app.c's common play sound file methods) to 'listen' for when the sound file has finished, then use redirects to send the DTMF.
    
    Hopefully that won't be necessary, as that does make the test more complex.



/asterisk/trunk/tests/predial/run-test
<https://reviewboard.asterisk.org/r/2006/#comment12561>

    You don't need this



/asterisk/trunk/tests/predial/run-test
<https://reviewboard.asterisk.org/r/2006/#comment12562>

    The default value for passed is False



/asterisk/trunk/tests/predial/run-test
<https://reviewboard.asterisk.org/r/2006/#comment12564>

    This can be written:
    
    self.test_series += 1



/asterisk/trunk/tests/predial/run-test
<https://reviewboard.asterisk.org/r/2006/#comment12563>

    self.test_count += 1



/asterisk/trunk/tests/predial/run-test
<https://reviewboard.asterisk.org/r/2006/#comment12565>

    May as well remove these



/asterisk/trunk/tests/predial/test-config.yaml
<https://reviewboard.asterisk.org/r/2006/#comment12566>

    Tags are generally only useful if we expect there to be multiple tests for a particular component or if a number of tests have some logical group.  A single test can be run with the '--test' option.
    
    If you think there will be more predial tests then by all means keep it - otherwise, it may not be needed.
    
    (This may, however, be useful for the Dial and FollowMe applications - which could have more tests)


- Matt


On June 29, 2012, 5:34 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2006/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 5:34 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Exercises the Dial and FollowMe applications predial subroutine handlers.
> 
> 
> This addresses bug SWP-4204.
>     https://issues.asterisk.org/jira/browse/SWP-4204
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/predial/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/tests.yaml 3284 
>   /asterisk/trunk/tests/predial/configs/ast1/followme.conf PRE-CREATION 
>   /asterisk/trunk/tests/predial/run-test PRE-CREATION 
>   /asterisk/trunk/tests/predial/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2006/diff
> 
> 
> Testing
> -------
> 
> The test passes.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120705/285521db/attachment-0001.htm>