[asterisk-dev] [Code Review] fix compiling warnings for chan_ooh323

[may213]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1767/#review6609
-----------------------------------------------------------

Ship it!


Sorry, not seen this review in a time.

Few corrected patch in the trunk at rev 369602/369603.
Just return by negative return value in ooh323 threads handlers in not a way due to per thread handler we must drop his thread from the list of idle threads, per select thread from list routine we must create new one.


- may213


On Feb. 23, 2012, 9:20 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1767/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 9:20 a.m.)
> 
> 
> Review request for Asterisk Developers and may213.
> 
> 
> Summary
> -------
> 
> I spend sometime cleaning up the compiler warnings, some big issues revolve around the fact that read() and write() return values are ignored.  Not safe from what I read.  Any suggestions / recommendations if I have handled it right?
> 
> 
> Diffs
> -----
> 
>   branches/1.8/addons/ooh323c/src/memheap.c 356432 
>   branches/1.8/addons/ooh323c/src/ooCapability.c 356432 
>   branches/1.8/addons/ooh323c/src/ooSocket.c 356432 
>   branches/1.8/addons/ooh323c/src/ooTimer.c 356432 
>   branches/1.8/addons/ooh323c/src/ooq931.c 356432 
>   branches/1.8/addons/ooh323c/src/perutil.c 356432 
>   branches/1.8/addons/ooh323cDriver.c 356432 
> 
> Diff: https://reviewboard.asterisk.org/r/1767/diff
> 
> 
> Testing
> -------
> 
> compiling testing on development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120704/ef89a321/attachment.htm>