[asterisk-dev] [Code Review]: Add Expires header to SIP PUBLISH responses

[Olle E. Johansson]

29 jun 2012 kl. 16:58 skrev Mark Michelson:

> On 06/29/2012 09:33 AM, Paul Belanger wrote:
>> On 12-06-29 03:43 AM, Olle E Johansson wrote:
>>>> On June 28, 2012, 11:16 a.m., Olle E Johansson wrote:
>>>>> Are we sure that we actually send another PUBLISH before the current one expires?
>>>> 
>>>> gareth wrote:
>>>>     This change only affects responses to PUBLISH requests. It would be up to the sending device to refresh the dialog.
>>> 
>>> If you PUBLISH and the event expires, you are supposed to update your PUBLISH. This needs to be in the PUBLISH framework. If you add expiry, this needs to mean something in the code.
>>> 
>>> A presence server will erase your state at expiry otherwise, which is NOT what you want.
>>> 
>> Is there any way to test this with SIPp?  Seems like it would be good to get some tests for this.
>> 
> Currently, the only way to get Asterisk to send a PUBLISH at all is via a call completion scenario wherein a recall fails due to the recipient of the call being busy. Trying to set up a situation with multiple dialogs in SIPp typically is quite difficult.
> 
I have code that sends PUBLISh with dialog-info in Asterisk. You wrote it in a very generic way, which was a good solution. Changes to the generic framework needs to be generic to allow for future extensions (in my opinion).

/O