[asterisk-dev] [Code Review] Add IPv6 Address Support To Security Events Framework

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1777/
-----------------------------------------------------------

(Updated Feb. 29, 2012, 11:58 a.m.)


Review request for Asterisk Developers.


Changes
-------

Update patch to address Simon's comments.


Summary
-------

The current API supports only IPv4 for security events. 

*  This patch changes the API to support IPv6 and updates the components that use this API.

*  It quiets a warning that is being displayed if binding to IPv6 and IPv4 ( udpbindaddr=:: ). 

*  It also eliminates an error that was being generated since the current implementation was treating an IPv6 socket address as if it was IPv4.

*  Some copyright dates were updated as well.


This addresses bug ASTERISK-19447.
    https://issues.asterisk.org/jira/browse/ASTERISK-19447


Diffs (updated)
-----

  /trunk/CHANGES 357541 
  /trunk/channels/chan_sip.c 357541 
  /trunk/channels/sip/security_events.c 357541 
  /trunk/include/asterisk/security_events_defs.h 357541 
  /trunk/main/manager.c 357541 
  /trunk/main/security_events.c 357541 

Diff: https://reviewboard.asterisk.org/r/1777/diff


Testing
-------

Tested SIP implementation on CentOS 5.7, connected with IPv4 clients and IPv6 clients.  Also tested SIP on Fedora 16 vm with IPv4.  Security log now shows IPv4 or IPv6 addresses when a security event is generated.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120229/d37b1098/attachment.htm>