[asterisk-dev] [Code Review] Add ability to reload SRTP policies

Bernard Merindol (F) Bernard.Merindol at free.fr
Mon Feb 27 03:53:39 CST 2012


Hi,

I have tested this new version and not works with Aastra phone.

But if you change chan_sip.c 

	/* For now, when we receive an INVITE just take the first successful crypto line */
       if ((*srtp)->crypto && !ast_test_flag(&p->flags[0], SIP_OUTGOING)) {
               ast_debug(3, "We've already processed a crypto attribute, skipping '%s'\n", a);
               return FALSE;                                                                                                                                 
       }

by
	/* For now, when we receive an INVITE just take the first successful crypto line */
       if ((*srtp)->crypto && !ast_test_flag(&p->flags[0], SIP_OUTGOING)) {
               ast_debug(3, "We've already processed a crypto attribute, skipping '%s'\n", a);
               // return FALSE;                                                                                                                                 
       }

Is works fine.

In issue ASTERISK-17505  this change is proposed.

Best regards
Bernard
On 25 févr. 2012, at 18:11, Matthew Jordan wrote:

> 
>> Hi,
> 
>> I hope is resolve this issue:
> 
>> https://issues.asterisk.org/jira/browse/ASTERISK-17505
> 
>> Best regards
>> Bernard Merindol
> 
> Based on the information in that issue, it appears that it will.  Would
> you mind testing it out and replying on that issue if it does indeed
> fix it?
> 
> Thanks,
> 
> Matthew Jordan
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at: http://digium.com & http://asterisk.org
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>  http://lists.digium.com/mailman/listinfo/asterisk-dev




More information about the asterisk-dev mailing list