[asterisk-dev] [Code Review]: Add tests for connected line, redirecting, and csss to test new gosub calls

[opticron]

> On Feb. 22, 2012, 12:34 p.m., Paul Belanger wrote:
> > Only made it 1/2 through, but same comments apply.  I see a lot of duplicate code in the runtest.py, any chance of moving the code to another class we can share?
> > 
> > It will help the maintainers.
> > 
> > Also, we should avoid using Wait(10), or any other number in dialplan logic.  We cannot be sure a system running the test will have enough time to run the code.

Addressed for connected line and redirecting tests only.  The CCSS test still needs some love.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1761/#review5587
-----------------------------------------------------------


On Feb. 21, 2012, 7:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1761/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2012, 7:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.
> 
> 
> This addresses bug SWP-4254.
>     https://issues.asterisk.org/jira/browse/SWP-4254
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3036 
>   asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/tests.yaml 3036 
> 
> Diff: https://reviewboard.asterisk.org/r/1761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/0a5658f2/attachment.htm>