[asterisk-dev] [Code Review] Audit and reformat IAX2 definitions to match the IANA-registered values.

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/672/#review5626
-----------------------------------------------------------

Ship it!


It looks like the IANA assignments have been updated to reflect our implementation, so this is no longer an issue.  It's up to you whether to update the source from decimal to hex, but I think you're good to go either way.

- Sean


On May 21, 2010, 9:04 a.m., Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/672/
> -----------------------------------------------------------
> 
> (Updated May 21, 2010, 9:04 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While preparing to document some new possible IAX2 support, I cross-checked the IAX2 control subclass and information element definitions in iax2.h against the registered values in the IANA registries. This comparison was harder than it needed to be because the values in iax2.h were in decimal and not hexadecimal, so the attached patch changes that.
> 
> However, while doing this comparison, I found a mismatch that we'll need to discuss how to address. We are using 0x34 as IAX_IE_VARIABLE but in the IANA registry this value is for IAX_IE_OSPTOKEN (which we have 0x35 for). Changing this will break backwards compatibility, but as it stands, we are not compatible with the IANA-registered definitions, so something has to change or implementations written to the specifications won't interoperate with Asterisk properly.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/iax2.h 264951 
> 
> Diff: https://reviewboard.asterisk.org/r/672/diff
> 
> 
> Testing
> -------
> 
> Compile testing; there are no functional changes here yet.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/e1e55b09/attachment.htm>