[asterisk-dev] [Code Review] Add tests for connected line, redirecting, and csss to test new gosub calls

Wed Feb 22 12:34:19 CST 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1761/#review5586
-----------------------------------------------------------

Only made it 1/2 through, but same comments apply.  I see a lot of duplicate code in the runtest.py, any chance of moving the code to another class we can share?

It will help the maintainers.

Also, we should avoid using Wait(10), or any other number in dialplan logic.  We cannot be sure a system running the test will have enough time to run the code. 

asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10233>

    any way to do this with our wait?

    Maybe echo()

asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10234>

    again, we should not be using Wait() commands.

asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10235>

    same

asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10236>

    udpbindaddr

asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10237>

    same

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10223>

    these are not needed, you can access them via self.ami[0] and self.ami[1].  Or self.ami[ami.id]

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10224>

    I'd rather see this in the TestCase class.

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10227>

    not needed

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10225>

    remove?

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10226>

    self.ami[0].registerEvent()

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10228>

    same as above

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10229>

    please use logger

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10230>

    same

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10231>

    same

asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10232>

    same

asterisk/trunk/tests/connected_line/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10238>

    1 is implied

asterisk/trunk/tests/connected_line/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10239>

    logger

asterisk/trunk/tests/connected_line/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10240>

    same

asterisk/trunk/tests/connected_line/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10241>

    same

asterisk/trunk/tests/connected_line/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10242>

    implied (1)

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10243>

    can be removed

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10244>

    1 can be removed

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10245>

    logger

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10246>

    same

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10247>

    same

asterisk/trunk/tests/connected_line/subroutine/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10248>

    1 implied

asterisk/trunk/tests/redirecting/macro/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10249>

    same as before

- Paul

On Feb. 21, 2012, 7:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1761/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2012, 7:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.
> 
> 
> This addresses bug SWP-4254.
>     https://issues.asterisk.org/jira/browse/SWP-4254
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3036 
>   asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/tests.yaml 3036 
> 
> Diff: https://reviewboard.asterisk.org/r/1761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/b96d073c/attachment-0001.htm>