[asterisk-dev] [Code Review] Opaquify ast_format structs in the ast_channel

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1770/#review5617
-----------------------------------------------------------

Ship it!


reviewing this is sooooooooooooo fun

- Mark


On Feb. 23, 2012, 4:26 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1770/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 4:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Opaquifiy the ast_channel structs by just adding a getter function that returns the pointer. That pointer can then be used with the ast_format APIs.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_mobile.c 356474 
>   /trunk/addons/chan_ooh323.c 356474 
>   /trunk/apps/app_amd.c 356474 
>   /trunk/apps/app_chanspy.c 356474 
>   /trunk/apps/app_confbridge.c 356474 
>   /trunk/apps/app_dictate.c 356474 
>   /trunk/apps/app_dumpchan.c 356474 
>   /trunk/apps/app_fax.c 356474 
>   /trunk/apps/app_festival.c 356474 
>   /trunk/apps/app_ices.c 356474 
>   /trunk/apps/app_meetme.c 356474 
>   /trunk/apps/app_mp3.c 356474 
>   /trunk/apps/app_nbscat.c 356474 
>   /trunk/apps/app_record.c 356474 
>   /trunk/apps/app_speech_utils.c 356474 
>   /trunk/apps/app_talkdetect.c 356474 
>   /trunk/apps/app_test.c 356474 
>   /trunk/apps/app_voicemail.c 356474 
>   /trunk/apps/app_waitforsilence.c 356474 
>   /trunk/bridges/bridge_multiplexed.c 356474 
>   /trunk/bridges/bridge_simple.c 356474 
>   /trunk/bridges/bridge_softmix.c 356474 
>   /trunk/channels/chan_agent.c 356474 
>   /trunk/channels/chan_alsa.c 356474 
>   /trunk/channels/chan_bridge.c 356474 
>   /trunk/channels/chan_console.c 356474 
>   /trunk/channels/chan_dahdi.c 356474 
>   /trunk/channels/chan_gtalk.c 356474 
>   /trunk/channels/chan_iax2.c 356474 
>   /trunk/channels/chan_jingle.c 356474 
>   /trunk/channels/chan_local.c 356474 
>   /trunk/channels/chan_mgcp.c 356474 
>   /trunk/channels/chan_misdn.c 356474 
>   /trunk/channels/chan_multicast_rtp.c 356474 
>   /trunk/channels/chan_nbs.c 356474 
>   /trunk/channels/chan_oss.c 356474 
>   /trunk/channels/chan_phone.c 356474 
>   /trunk/channels/chan_sip.c 356474 
>   /trunk/channels/chan_skinny.c 356474 
>   /trunk/channels/chan_unistim.c 356474 
>   /trunk/channels/chan_usbradio.c 356474 
>   /trunk/channels/chan_vpb.cc 356474 
>   /trunk/funcs/func_channel.c 356474 
>   /trunk/include/asterisk/channel.h 356474 
>   /trunk/main/app.c 356474 
>   /trunk/main/bridging.c 356474 
>   /trunk/main/channel.c 356474 
>   /trunk/main/channel_internal_api.c 356474 
>   /trunk/main/cli.c 356474 
>   /trunk/main/features.c 356474 
>   /trunk/main/file.c 356474 
>   /trunk/main/indications.c 356474 
>   /trunk/main/pbx.c 356474 
>   /trunk/main/rtp_engine.c 356474 
>   /trunk/res/res_adsi.c 356474 
>   /trunk/res/res_agi.c 356474 
>   /trunk/res/res_calendar.c 356474 
>   /trunk/res/res_fax.c 356474 
>   /trunk/res/res_musiconhold.c 356474 
> 
> Diff: https://reviewboard.asterisk.org/r/1770/diff
> 
> 
> Testing
> -------
> 
> It compiles and the unit tests run successfully.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/2fe339c4/attachment.htm>