[asterisk-dev] [Code Review]: fix compiling warnings for chan_ooh323

Paul Belanger reviewboard at asterisk.org
Thu Feb 23 09:20:24 CST 2012



> On Feb. 23, 2012, 9:11 a.m., Matt Jordan wrote:
> > branches/1.8/addons/ooh323cDriver.c, lines 103-107
> > <https://reviewboard.asterisk.org/r/1767/diff/1/?file=24523#file24523line103>
> >
> >     Returning here changes the behavior of this function.  If res is unused, then - from the perspective of only fixing a compiler warning, and not change the semantics of this portion of the code - you shouldn't check the return value of this call.
> >     
> >     That being said, Alexander Anikin (may123) is the man when it comes to chan_ooh323, so you should probably ask him.
> >     
> >

Ya, I am fine with that, however it would create another warning:

ooh323cDriver.c:103:7: error: ignoring return value of 'read', declared with attribute warn_unused_result [-Werror=unused-result]



More information about the asterisk-dev mailing list