[asterisk-dev] [Code Review] Convert app_page to use app_confbridge internally

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1754/#review5559
-----------------------------------------------------------



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1754/#comment10188>

    Is this going to block while the announcement is played?  Is it ok to block with the conf bridge lock held?



/trunk/apps/app_page.c
<https://reviewboard.asterisk.org/r/1754/#comment10189>

    One of these days, we should make this return a ref counted object ... (not necessary to do in this patch, of course)



/trunk/apps/confbridge/conf_config_parser.c
<https://reviewboard.asterisk.org/r/1754/#comment10190>

    I guess this should be added to CHANGES



/trunk/apps/confbridge/conf_config_parser.c
<https://reviewboard.asterisk.org/r/1754/#comment10191>

    Seems like overkill when just setting the first byte to 0 is sufficient


- Russell


On Feb. 20, 2012, 10:33 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1754/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 10:33 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The Page application was originally written to use MeetMe internally but as development has progressed ConfBridge has become the new favored conference bridge application. This task was originally to change Page to use the bridging API internally but that proved to be too low level and numerous features from ConfBridge would have been duplicated. Page has therefore been rewritten to use ConfBridge internally.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 355010 
>   /trunk/apps/app_page.c 355010 
>   /trunk/apps/confbridge/conf_config_parser.c 355010 
>   /trunk/apps/confbridge/include/confbridge.h 355010 
>   /trunk/include/asterisk/dial.h 355010 
>   /trunk/main/dial.c 355010 
> 
> Diff: https://reviewboard.asterisk.org/r/1754/diff
> 
> 
> Testing
> -------
> 
> Tested Paging multiple phones with different combinations of features.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120220/d731cfc3/attachment-0001.htm>