[asterisk-dev] [Code Review] Make ast_unload_resource actually remove the module from the module list when it is unloaded

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1752/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

res_calendar calls ast_unload_resource for the related tech modules when it is unloaded. If this happens through a 'core stop gracefully', then it will be unloading the tech modules that are already in the list that is being traversed (supposedly safely) for unloading, eventually causing a double free. The problem seems to be that ast_unload_resource, while it calls the unload() callback function for the module, does not actually unlink the module from the list of modules. So the AST_LIST_TRAVERSE_SAFE_BEGIN {} still iterates over the unloaded module.

This patch causes ast_unload_resource to call AST_LIST_REMOVE on successfully unloaded modules.


Diffs
-----

  /trunk/main/loader.c 355783 

Diff: https://reviewboard.asterisk.org/r/1752/diff


Testing
-------

Scenario: Start Asterisk with res_calendar and assorted calendar tech modules loaded. Run 'core stop gracefully'.
Before patch: Crash.
After patch: No crash.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120218/e793d367/attachment.htm>