[asterisk-dev] [Code Review] Fixing the regression from wrong set route information on provisional sip responses

[schmidts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1749/
-----------------------------------------------------------

(Updated Feb. 16, 2012, 3:58 p.m.)


Review request for Asterisk Developers and wdoekes.


Changes
-------

honoring marks suggestion i changed the parameter for build_route to the response code. only if the response code is between 100 and 199 the route set will not be persistant.s


Summary
-------

by adding the parse_ok_header and build_route for provisional responses to invite. I had caused a regression that asterisk stores a wrong route set from this provisional packets. With this change a route set from a provisionial response will not be stored persistant and will be replaced with the route information from a 200 ok packet.
see bug ASTERISK-19358 for more information and sip traces.


This addresses bug ASTERISK-19358.
    https://issues.asterisk.org/jira/browse/ASTERISK-19358


Diffs (updated)
-----

  branches/1.8/channels/chan_sip.c 355573 

Diff: https://reviewboard.asterisk.org/r/1749/diff


Testing
-------

tested with the sipp scenario from wdoekes (thank you for this).


Thanks,

schmidts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120216/dc9722a7/attachment.htm>