[asterisk-dev] [Code Review] No valid transports available, falling back to 'udp'

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1745/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

In r347727 I introduced an extra warning for anyone who doesn't have any transport= set. This causes confusion, especially since that setting isn't in [general] in the sip.conf.sample.

I could tone down the warning, but I'd rather fix it like this: only complain if transports= was supplied and ended up empty (because of invalid transports).

However, I'd like to change the behaviour of the transport= option for that.

Previously:
  transport=udp
  transport=tcp
meant:
  transport=udp,tcp
after this patch, it means:
  transport=tcp

Which is odd, since other options don't behave like that (apart from allow/deny/permit/disallow). insecure=port and insecure=invite means insecure=invite and not the combination of the two.

However, somebody somewhere probably relies on current behaviour.. or?


This addresses bug ASTERISK-19352.
    https://issues.asterisk.org/jira/browse/ASTERISK-19352


Diffs
-----

  /branches/1.8/channels/chan_sip.c 355531 

Diff: https://reviewboard.asterisk.org/r/1745/diff


Testing
-------

Tested that only the last transport= setting for [general] and for peers is used and that the warning is gone if no transport= is supplied in [general]. I didn't run the test-suite (yet).


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120215/a3bf617c/attachment.htm>