[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

[KNK]

> On Jan. 18, 2012, 4:54 a.m., wdoekes wrote:
> > trunk/mtp3.c, line 1097
> > <https://reviewboard.asterisk.org/r/1653/diff/5/?file=23411#file23411line1097>
> >
> >     Are the parentheses around NET_* needed?
> 
> KNK wrote:
>     Yes, as it is defined as 0x07 | 0x10 (so are all other NET_MNG_XXX messages)
> 
> rmudgett wrote:
>     Then those defines should be fixed to add the necessary insulating parentheses to avoid potential future surprises.  Otherwise that code looks odd.

I haven't touched that part of the code, because it was outside of the changes from 13495, but fixing the definitions now while i am here


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review5207
-----------------------------------------------------------


On Feb. 15, 2012, 4:17 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2012, 4:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes only
> 
> 
> This addresses bugs SS7-27, SS7-52 and SS7-53.
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
> 
> 
> Diffs
> -----
> 
>   trunk/isup.h 296 
>   trunk/isup.c 296 
>   trunk/libss7.h 296 
>   trunk/mtp2.h 296 
>   trunk/mtp2.c 296 
>   trunk/mtp3.h 296 
>   trunk/mtp3.c 296 
>   trunk/ss7.c 296 
>   trunk/ss7_internal.h 296 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120215/0d8bd18d/attachment-0001.htm>