[asterisk-dev] [Code Review]: chan_dahdi: Add dialtonedetect option

[Jeremy Pepper]

> On Feb. 14, 2012, 2:43 a.m., Alec Davis wrote:
> > trunk/channels/chan_dahdi.c, line 9260
> > <https://reviewboard.asterisk.org/r/1737/diff/3/?file=24167#file24167line9260>
> >
> >     can't we just use !p->outgoing instead of ast_test_flag(ast, AST_FLAG_OUTGOING)

At least when I tried this in 1.8.8.1, there was a bug where inbound calls would be flagged as outgoing after the channel had been used for one outgoing call. I can retest this with Asterisk from trunk if you'd like.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/#review5495
-----------------------------------------------------------


On Feb. 13, 2012, 7:16 p.m., Jeremy Pepper wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1737/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 7:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi: Add dialtonedetect option
> 
> This adds an option to chan_dahdi.conf called dialtonedetect. This can be set like this:
> 
>     dialtonedetect = yes ; Watch for dialtone for 10 seconds after answer
>     dialtonedetect = always ; Watch for dialtone for the whole call
>     dialtonedetect = 5000 ; Watch for dialtone for 5000ms
> 
> If dialtone is detected on an inbound call, Asterisk will hang up the channel.
> 
> 
> This addresses bug ASTERISK-19316.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19316
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 354459 
>   trunk/channels/chan_dahdi.c 354459 
> 
> Diff: https://reviewboard.asterisk.org/r/1737/diff
> 
> 
> Testing
> -------
> 
> This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtonedetect off, set to always, set to yes, and set to a custom value.
> 
> 
> Thanks,
> 
> Jeremy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120214/72cbae19/attachment.htm>