[asterisk-dev] [Code Review] chan_dahdi: Add dialtonedetect option

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/#review5494
-----------------------------------------------------------

Ship it!


Looks good.  Just some comments to update.


trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1737/#comment10121>

    Value is now:
    Number of samples



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1737/#comment10122>

    Samples elapsed.



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1737/#comment10123>

    A comment indicating why we are hanging up would be good here.



trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/1737/#comment10120>

    Typo
    dial tone to detection => dial tone detection


- rmudgett


On Feb. 13, 2012, 7:16 p.m., Jeremy Pepper wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1737/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 7:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi: Add dialtonedetect option
> 
> This adds an option to chan_dahdi.conf called dialtonedetect. This can be set like this:
> 
>     dialtonedetect = yes ; Watch for dialtone for 10 seconds after answer
>     dialtonedetect = always ; Watch for dialtone for the whole call
>     dialtonedetect = 5000 ; Watch for dialtone for 5000ms
> 
> If dialtone is detected on an inbound call, Asterisk will hang up the channel.
> 
> 
> This addresses bug ASTERISK-19316.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19316
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 354459 
>   trunk/channels/chan_dahdi.c 354459 
> 
> Diff: https://reviewboard.asterisk.org/r/1737/diff
> 
> 
> Testing
> -------
> 
> This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtonedetect off, set to always, set to yes, and set to a custom value.
> 
> 
> Thanks,
> 
> Jeremy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120214/2495af2c/attachment.htm>