[asterisk-dev] [Code Review] Add AGIEXITONHANGUP variable.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1734/#review5484
-----------------------------------------------------------

Ship it!


Seems like a reasonable change to me.


/trunk/res/res_agi.c
<https://reviewboard.asterisk.org/r/1734/#comment10100>

    You can just call ast_true() here. ast_true() calls ast_strlen_zero() itself and will return 0 if ast_strlen_zero() evaluates true.


- Mark


On Feb. 12, 2012, 1:05 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1734/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 1:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a variable AGIEXITONHANGUP for res_agi.  If this variable is set to "yes" on a channel, AGI() will exit immediately once a channel hangup has been detected.  This was the behavior of AGI() in Asterisk 1.4 and earlier and is still desired by some people.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 354937 
>   /trunk/res/res_agi.c 354937 
> 
> Diff: https://reviewboard.asterisk.org/r/1734/diff
> 
> 
> Testing
> -------
> 
> Wrote a simple AGI script that executes HANGUP and observed differences in behavior between Asterisk versions and then with/without this variable enabled.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120213/e21e6bd4/attachment.htm>