[asterisk-dev] [Code Review] Fix parsing of SIP headers where compact and non-compact headers are mixed

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1728/#review5475
-----------------------------------------------------------

Ship it!


Looks good to me. The old way is dumb.

- Mark


On Feb. 9, 2012, 1:21 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1728/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 1:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Change parsing of SIP headers so that compactness of the header no longer influences which header will be chosen.  Previously, a non-compact header would be chosen instead of a preceeding compact-form header.
> 
> 
> This addresses bug ASTERISK-17192.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17192
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 354311 
> 
> Diff: https://reviewboard.asterisk.org/r/1728/diff
> 
> 
> Testing
> -------
> 
> Checked parsing with the testsuite to ensure nothing broke and added a test to check for this:
> https://reviewboard.asterisk.org/r/1729/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/ee15cf9b/attachment.htm>