[asterisk-dev] [Code Review] Make the config parser remove escaping backslashes

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1724/#review5472
-----------------------------------------------------------

Ship it!


Seems like the right fix. Go for it.

- Mark


On Feb. 9, 2012, 1:12 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1724/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2012, 1:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The config parser in Asterisk does not currently remove a backslash that is used to escape a semicolon which would otherwise be interpreted as the start of a comment.
> 
> The change here causes that backslash to be removed, but does not create a real escape system in the config parser.  The biggest complication with a real escape system would be breaking existing configs everywhere (parsing \\ as \ and breaking on escaped non-semicolon characters) even though it would be the "right" way to do things.  It also does not confer any benefits because there are no other escaped characters that have special meaning in config files.
> 
> 
> This addresses bug ASTERISK-17121.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17121
> 
> 
> Diffs
> -----
> 
>   trunk/main/config.c 354311 
> 
> Diff: https://reviewboard.asterisk.org/r/1724/diff
> 
> 
> Testing
> -------
> 
> Manual checking done and addtion to testsuite here:
> https://reviewboard.asterisk.org/r/1727/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/329ecbad/attachment.htm>