[asterisk-dev] [Code Review] Document that CDRs cannot be modified after the bridge between two channels is broken

Joshua Colp reviewboard at asterisk.org
Thu Feb 9 10:35:53 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1720/#review5466
-----------------------------------------------------------

Ship it!


I'm personally fine with this, I know how hard and dangerous it would be to try to even remotely change this. Having it documented is gooood.

- Joshua


On Feb. 7, 2012, 4:32 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1720/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 4:32 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CDRs are written when the bridge between two channels is broken. Therefor doing something like
> exten => s,1,Dial(SIP/blah,,g) ; continue after hangup
> exten => s,n,Set(CDR(userfield)=blah)
> 
> is not possible. This patch adds a note to the CDR() documentation making this explicit.
> 
> 
> This addresses bug ASTERISK-16923.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16923
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/funcs/func_cdr.c 354347 
> 
> Diff: https://reviewboard.asterisk.org/r/1720/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120209/08d2872c/attachment-0001.htm>


More information about the asterisk-dev mailing list