[asterisk-dev] [Code Review] Add reload support to res_fax

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1713/#review5416
-----------------------------------------------------------



/branches/1.8/res/res_fax.c
<https://reviewboard.asterisk.org/r/1713/#comment10000>

    Although you're not changing how this works, I think you're actually doing it wrong here.  If there's an issue with an option in the middle of the configuration file, then you set previous-settings + all-options-so-far.  I think the correct behavior should be:  if you encounter a nonrecoverable error in the configuration file, then you should error out and set NO options at all.  This then preserves existing options, instead of implementing a partial configuration.
    
    In other words, move the end: label down by one line.


- Tilghman


On Feb. 3, 2012, 11:26 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1713/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2012, 11:26 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Since res_fax has configurable options, it needs reload support. This patch adds reload support to res_fax.
> 
> 
> This addresses bug ASTERISK-16712.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16712
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/res/res_fax.c 353917 
> 
> Diff: https://reviewboard.asterisk.org/r/1713/diff
> 
> 
> Testing
> -------
> 
> Confirmed that "module reload res_fax.so" is operational and properly loads new configuration options.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120204/afdbef44/attachment.htm>