[asterisk-dev] [Code Review] Replace res_ais with a new module, res_corosync.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1700/#review5398
-----------------------------------------------------------

Ship it!


Looks sane to me.


/trunk/res/res_corosync.c
<https://reviewboard.asterisk.org/r/1700/#comment9969>

    You could condense this all into a getnameinfo() call if you wanted.



/trunk/res/res_corosync.c
<https://reviewboard.asterisk.org/r/1700/#comment9968>

    You should protect this traversal with the event_types_lock (readlock, to be specific)



/trunk/res/res_corosync.c
<https://reviewboard.asterisk.org/r/1700/#comment9967>

    ast_config_load() will only return CONFIG_STATUS_FILEUNCHANGED if you have passed in CONFIG_FLAG_FILEUNCHANGED as a flag. This can't happen currently.


- Mark


On Jan. 28, 2012, 8:54 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1700/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 8:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
>     This patch removes res_ais and introduces a new module, res_corosync.
>     The OpenAIS project is deprecated and is now just a wrapper around
>     Corosync.  This module provides the same functionality using the same
>     core infrastructure, but without the use of the deprecated components.
>     
>     Technically res_ais could have been used with an AIS implementation other
>     than OpenAIS, but that is the only one I know of that was ever used.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 353176 
>   /trunk/UPGRADE.txt 353176 
>   /trunk/build_tools/menuselect-deps.in 353176 
>   /trunk/configs/ais.conf.sample 353177 
>   /trunk/configs/res_corosync.conf.sample PRE-CREATION 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 353176 
>   /trunk/include/asterisk/autoconfig.h.in 353176 
>   /trunk/makeopts.in 353176 
>   /trunk/res/ais/ais.h 353177 
>   /trunk/res/ais/clm.c 353177 
>   /trunk/res/ais/evt.c 353177 
>   /trunk/res/res_ais.c 353177 
>   /trunk/res/res_corosync.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1700/diff
> 
> 
> Testing
> -------
> 
> I set up 2 nodes and verified that device states were passed between them.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120203/9b2d0cbc/attachment-0001.htm>