[asterisk-dev] [Code Review]: Remove some dead code found in _sip_show_peers()

[jrose]

> On Jan. 26, 2012, 9:30 p.m., Terry Wilson wrote:
> > I can't help myself. From the coding guidelines:
> > 
> >      Don't make unnecessary whitespace changes throughout the code. If you make changes, submit them to the tracker as separate patches that only include whitespace and formatting changes.
> > 
> > :-)
> 
> Paul Belanger wrote:
>     Funny you say that, I was under the impression in trunk it was not a problem.
> 
> Terry Wilson wrote:
>     It's ok to make whitespace changes, just not mix them in with actual bug fixes. It makes finding what has really changed a lot more difficult.

I'm pretty sure it's OK in general to do white space changes as long as you are editing code that is in the area you are working on.

That said, I was mucking about in _sip_show_peers today as well, so I might have hit a lot of these when I was doing my thing earlier.  I'm not sure what that means in the grand scheme of this patch, but a new diff should probably be posted at the very least and I wouldn't be at all surprised if there were like a dozen conflicts.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1696/#review5323
-----------------------------------------------------------


On Jan. 26, 2012, 10:59 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1696/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 10:59 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I was poking around in chan_sip last night (scary right?) and notice what appears to be some dead code.  This patch removes it and also includes come coding guidelines.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 352754 
> 
> Diff: https://reviewboard.asterisk.org/r/1696/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120202/60433f51/attachment.htm>