[asterisk-dev] [Code Review]: Remove some dead code found in _sip_show_peers()
Paul Belanger
reviewboard at asterisk.org
Thu Feb 2 10:08:40 CST 2012
> On Jan. 26, 2012, 9:30 p.m., Terry Wilson wrote:
> > I can't help myself. From the coding guidelines:
> >
> > Don't make unnecessary whitespace changes throughout the code. If you make changes, submit them to the tracker as separate patches that only include whitespace and formatting changes.
> >
> > :-)
Funny you say that, I was under the impression in trunk it was not a problem.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1696/#review5323
-----------------------------------------------------------
On Jan. 26, 2012, 10:59 a.m., Paul Belanger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1696/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2012, 10:59 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> I was poking around in chan_sip last night (scary right?) and notice what appears to be some dead code. This patch removes it and also includes come coding guidelines.
>
>
> Diffs
> -----
>
> trunk/channels/chan_sip.c 352754
>
> Diff: https://reviewboard.asterisk.org/r/1696/diff
>
>
> Testing
> -------
>
> local development box
>
>
> Thanks,
>
> Paul
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120202/48a669c5/attachment.htm>
More information about the asterisk-dev
mailing list