[asterisk-dev] [Code Review]: chan_sip: [general] maxforwards, not checked for a value greater than 255

[Paul Belanger]

On 12-04-26 05:51 AM, Olle E. Johansson wrote:
>
> 26 apr 2012 kl. 11:37 skrev Alec Davis:
>
>> This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1888/
>>
>> On April 26th, 2012, 4:29 a.m., Olle E Johansson wrote:
>>
>> You are exactly right. My mistake. I can commit it if you can not. Just find me on IRC or e-mail.
>> I can commit.
>
> As I ask the US people to wait and not commit immediately, I would like for us on other time zones to respect them and at least keep a code review open for a day so there's room for discussion.
>
> Now this was such a small fix (and rather obvious) so I don't mind and I don't think we'll see any objection when they wake up.
>
> But in the future I ask all of us developers to be less trigger-happy with the commit after a ship-it on your time zone.
>
One thing I like about OpenStack development, their CI tool (jenkins) 
and review tool (gerrit) is responsible for committing the actual patch 
once it has been properly reviewed.  Having a bot responsible for 
commits allow greater flexibility for automation to do something like this.

I think the current thought process is, hey I have a ship it, must 
commit ASAP so I don't have to do it later.  Having a bot do it, we can 
introduce time frames for the commit to happen at a later point in time.

-- 
Paul Belanger
Digium, Inc. | Software Developer
twitter: pabelanger | IRC: pabelanger (Freenode)
Check us out at: http://digium.com & http://asterisk.org