[asterisk-dev] [Code Review]: Make it possible to change DTMF min duration in asterisk.conf

[Olle E Johansson]

> On April 24, 2012, 6:58 p.m., Alec Davis wrote:
> > /trunk/main/asterisk.c, lines 3206-3208
> > <https://reviewboard.asterisk.org/r/1882/diff/2/?file=27523#file27523line3206>
> >
> >     Assuming option_dtmfminduration can never be negative.
> >      
> >     Can't the test for option_dtmfminduration < 0 be covered by using '%30u' in the sscanf option.

Thanks for the review, Alec. Have changed according to your recommendations.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1882/#review6053
-----------------------------------------------------------


On April 24, 2012, 5:03 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1882/
> -----------------------------------------------------------
> 
> (Updated April 24, 2012, 5:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In channel.c there's a DEFINE for a minimum DTMF duration. I've changed this in many installations. It is much more convienient to be able to change this in asterisk.conf
> 
> Also shows up in "core show settings" for verification.
> 
> Will update CHANGES.
> 
> 
> This addresses bug 19772.
>     https://issues.asterisk.org/jira/browse/19772
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 363322 
>   /trunk/configs/asterisk.conf.sample 363322 
>   /trunk/include/asterisk/options.h 363322 
>   /trunk/main/asterisk.c 363322 
>   /trunk/main/channel.c 363322 
> 
> Diff: https://reviewboard.asterisk.org/r/1882/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120425/ab50f1eb/attachment.htm>