[asterisk-dev] [Code Review] Make it possible to change DTMF min duration in asterisk.conf

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1882/#review6043
-----------------------------------------------------------



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/1882/#comment11073>

    Would be ideal that it mentioned the option directly here so it's obvious what you might change.



/trunk/configs/asterisk.conf.sample
<https://reviewboard.asterisk.org/r/1882/#comment11074>

    Looks like a comment in the code says that the minimum can't be less than 80ms. Perhaps the wording just seems to imply that when what you meant to document was the default value.



/trunk/main/asterisk.c
<https://reviewboard.asterisk.org/r/1882/#comment11075>

    Assuming you just meant the default is 80ms, maybe s/80ms/Default value 80ms/
    
    When I first read this my brain processed it as you were stating what the minimum value was.


- Leif


On April 24, 2012, 5:03 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1882/
> -----------------------------------------------------------
> 
> (Updated April 24, 2012, 5:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In channel.c there's a DEFINE for a minimum DTMF duration. I've changed this in many installations. It is much more convienient to be able to change this in asterisk.conf
> 
> Also shows up in "core show settings" for verification.
> 
> Will update CHANGES.
> 
> 
> This addresses bug 19772.
>     https://issues.asterisk.org/jira/browse/19772
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 363322 
>   /trunk/configs/asterisk.conf.sample 363322 
>   /trunk/include/asterisk/options.h 363322 
>   /trunk/main/asterisk.c 363322 
>   /trunk/main/channel.c 363322 
> 
> Diff: https://reviewboard.asterisk.org/r/1882/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120424/b557f67c/attachment-0001.htm>