[asterisk-dev] [Code Review] Make it possible to change DTMF min duration in asterisk.conf

[Kaloyan Kovachev]

Hi,
 i can't add a comment to the review itself, so this small comment goes
here.
 at https://reviewboard.asterisk.org/r/1882/diff/#2.18 line 3207:

 option_dtmfminduration = 80;

shouldn't it be

 option_dtmfminduration = AST_MIN_DTMF_DURATION;

On Tue, 24 Apr 2012 09:34:58 -0000, "Olle E Johansson"
<reviewboard at asterisk.org> wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1882/
> -----------------------------------------------------------
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In channel.c there's a DEFINE for a minimum DTMF duration. I've changed
> this in many installations. It is much more convienient to be able to
> change this in asterisk.conf
> 
> Also shows up in "core show settings" for verification.
> 
> Will update CHANGES.
> 
> 
> This addresses bug 19772.
>     https://issues.asterisk.org/jira/browse/19772
> 
> 
> Diffs
> -----
> 
>   /trunk/main/channel.c 363322 
>   /trunk/include/asterisk/options.h 363322 
>   /trunk/main/asterisk.c 363322 
>   /trunk/configs/asterisk.conf.sample 363322 
> 
> Diff: https://reviewboard.asterisk.org/r/1882/diff
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Olle E