[asterisk-dev] [Code Review] Fix building of security events test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1874/#review6013
-----------------------------------------------------------

Ship it!


Thanks for fixing the unit tests!

- Matt


On April 18, 2012, 9:27 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1874/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 9:27 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The Security Events Framework API changed in trunk to support IPv6.  This breaks the building of the security events test which was based around IPv4.  This patches fixes the build by changing the test to conform to the new changes.
> 
> 
> This addresses bug ASTERISK-19447.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19447
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_security_events.c 362425 
> 
> Diff: https://reviewboard.asterisk.org/r/1874/diff
> 
> 
> Testing
> -------
> 
> On local dev machine, enabled the building of the test modules and now everything builds correctly.  Ran the test and it worked as well, although I need to add some security event generation testing for two new events that were added in 10 when adding security event generation to chan_sip.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120418/6f10b759/attachment.htm>