[asterisk-dev] [Code Review] Generate VMWI neon pulses from FXS module to light NEON lamp on older 'non intellegent phones'

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1144/
-----------------------------------------------------------

(Updated April 13, 2012, 5:12 a.m.)


Review request for Asterisk Developers and Shaun Ruffell.


Changes
-------

main changes were wctdm_set_ring_generator_mode, to call the interupt versions of wctdm_proslic_setreg_indirect_intr

otherwise lockup when restarting dahdi.


Summary
-------

Implement same code as for wcdtm


This addresses bug 14261.
    https://issues.asterisk.org/jira/browse/14261


Diffs (updated)
-----

  linux/trunk/drivers/dahdi/wctdm24xxp/wctdm24xxp.h 10660 
  linux/trunk/drivers/dahdi/wctdm24xxp/base.c 10660 

Diff: https://reviewboard.asterisk.org/r/1144/diff


Testing (updated)
-------

13/04/12
Tested with mwisendtype=lrev,hvac
at 2 different phones on same FXS port, one a real neon phone, and another a led+zener phone.
Left messages, and neon would flash as expected.

There is an issue that I think exists with the wctdm code as well, that is with some messages already waiting, thus neon is flashing, if another caller aborts the call and doesn't leave a message, the set_vmwi isn't called to re-enable the neon, the lrev is set correctly though.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120413/e6a5a410/attachment.htm>