[asterisk-dev] [Code Review] Triggers dialplan actions when specific CONTROL_FRAMES are detected on a channel

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1778/#review5958
-----------------------------------------------------------


A few thoughts:
* CONTROL_SOMETHING is a source code name and I don't like using that in userspace. There are a few events during the call and we should define them as names, instead of using the event names. 
* Enabling all the control frames is not even remotely needed and can possibly be an issue. Does this function receive it before or after or instead of the normal consumer? What state are we in. If you trigger on DTMF and the dial plan listens for DTMF (like in an IVR) then what happens?
* I suggest you add a channel variable to specify which event that triggered the execution

This needs a thorough architecture discussion.

- Olle E


On April 10, 2012, 5:47 a.m., Marco Signorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1778/
> -----------------------------------------------------------
> 
> (Updated April 10, 2012, 5:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A filter can be applied to the trigger to limit frames sensibility. This filter can either be a white or black list of control frame types. When no filter type is present, white is used. If no arguments are provided at all, all frames will trigger the specified gosub call.
> If the specified gosub extension is not present on the dialplan, the function will gosub to the "s-XXXX" extension in the gosub context where XXXX is the type of the control frame.
> It can be set only once on a given channel.
> 
> Examples:
> exten => 1,1,Set(FRAME_TRIGGER(white, CONTROL_HOLD)=ext,context); trigger gosub ext-CONTROL_HOLD at context only for HOLD type control frames
> exten => 1,1,Set(FRAME_TRIGGER(black, CONTROL_HOLD)=ext,context); trigger gosub ext-CONTROL_XXXX at context for all control type frames except for HOLD type control frames
> exten => 1,1,Set(FRAME_TRIGGER(CONTROL_HOLD, CONTROL_UNHOLD)=context) ; trigger gosub to s-CONTROL_HOLD at context and s-CONTROL_UNHOLD context only for HOLD and UNHOLD type control frames
> 
> This feature was originally developed in order to track MOH events in a call center environment but has general interest.
> 
> 
> This addresses bug ASTERISK-19319.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19319
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_frame_trigger.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1778/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120410/4932919c/attachment.htm>