[asterisk-dev] [Code Review]: Make MeetMeAdmin command N (mute all nonadmins) not mute admins

[jrose]

> On April 3, 2012, 4 p.m., Mark Michelson wrote:
> > I took a look at the review you linked to, and it appears the only thing the review in question changed was the behavior of the 'N' option. The 'K' and 'n' options were unchanged by that review. As a result, you are changing the behavior of the 'K' and 'n' options in this review request to something they've never done before. As much as it may make sense to operate this way, that's not how the options have ever behaved, so you need to revert those changes.

Alright, done.  Only change kept was the N option.

I'm not posting the new diff because it's just:

===================================================================
--- apps/app_meetme.c	(revision 361037)
+++ apps/app_meetme.c	(working copy)
@@ -4601,7 +4601,7 @@
 		user->adminflags |= ADMINFLAG_MUTED;
 		break;
 	case 78: /* N: Mute all (non-admin) users */
-		ao2_callback(cnf->usercontainer, OBJ_NODATA, user_set_muted_cb, NULL);
+		ao2_callback(cnf->usercontainer, OBJ_NODATA, user_set_muted_cb, &cnf);
 		break;					
 	case 109: /* m: Unmute */ 
 		user->adminflags &= ~(ADMINFLAG_MUTED | ADMINFLAG_SELFMUTED | ADMINFLAG_T_REQUEST);


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1843/#review5928
-----------------------------------------------------------


On April 3, 2012, 3:39 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1843/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 3:39 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This bug was introduced when jpeeler did a major overhaul in MeetMe to prevent deadlocks by using ao2_callbacks.  He added a condition which checked for the presence of a pointer to the conference which wasn't included with all of the ao2_callback calls which used those function pointers.  This patch looked over the other call to user_set_muted_cb which worked fine and applied the difference (inclusion of a pointer to the conference) elsewhere.
> 
> Noting that, I applied the same thing to a few other similar commands in the area.
> 
> https://reviewboard.asterisk.org/r/746/
> This is a review for the patch which appears to have introduced this.
> 
> 
> This addresses bug ASTERISK-19335.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19335
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_meetme.c 361037 
> 
> Diff: https://reviewboard.asterisk.org/r/1843/diff
> 
> 
> Testing
> -------
> 
> So far I've mostly just tested with the dialplan shown in the issue.  It appears to work properly now.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120403/61584c0c/attachment-0001.htm>