No subject
Fri Sep 2 03:59:05 CDT 2011
The SIP session timer mechanism contains a mandatory 'refresher' parameter =
(included in the Session-Expires header) which is used in the session timer=
offer/answer signaling within a SIP Invite dialog. It looks like asterisk =
is interpreting the uac resp. uas role only as the initial role of client a=
nd server (caller is uac, callee is uas). The standard rfc 4028 however ass=
igns the client role to the ((RE)-Invite) requester, the server role to the=
((RE)-Invite) responder.
This patch has Asterisk track the actual refresher as "us" or "them" as opp=
osed to relying on just the configured "uas" or "uac" properties.
This addresses bug AST-922.
https://issues.asterisk.org/jira/browse/AST-922
Diffs (updated)
-----
/branches/1.8/channels/chan_sip.c 373130 =
/branches/1.8/channels/sip/include/sip.h 373130 =
/branches/1.8/configs/sip.conf.sample 373130 =
Diff: https://reviewboard.asterisk.org/r/2118/diff
Testing
-------
Calls with clients supporting and not supporting session timers with Asteri=
sk having session-refresher=3Duas or uac.
Thanks,
Terry
--===============6441695765259744928==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
<html>
<body>
<div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href=3D"https://reviewboard.asterisk.org/r/2118/">https://reviewbo=
ard.asterisk.org/r/2118/</a>
</td>
</tr>
</table>
<br />
<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Thomas Arimont.</div>
<div>By Terry Wilson.</div>
<p style=3D"color: grey;"><i>Updated Sept. 19, 2012, 3:57 p.m.</i></p>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</=
h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Address mmichelson's review.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">From the issue:
The SIP session timer mechanism contains a mandatory 'refresher' pa=
rameter (included in the Session-Expires header) which is used in the sessi=
on timer offer/answer signaling within a SIP Invite dialog. It looks like a=
sterisk is interpreting the uac resp. uas role only as the initial role of =
client and server (caller is uac, callee is uas). The standard rfc 4028 how=
ever assigns the client role to the ((RE)-Invite) requester, the server rol=
e to the ((RE)-Invite) responder.
This patch has Asterisk track the actual refresher as "us" or &qu=
ot;them" as opposed to relying on just the configured "uas" =
or "uac" properties.</pre>
</td>
</tr>
</table>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
<tr>
<td>
<pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Calls with clients supporting and not supporting session tim=
ers with Asterisk having session-refresher=3Duas or uac.</pre>
</td>
</tr>
</table>
<div style=3D"margin-top: 1.5em;">
<b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href=3D"https://issues.asterisk.org/jira/browse/AST-922">AST-922</a>
</div>
<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
(updated)</h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style=3D"color: grey">(373130)=
</span></li>
<li>/branches/1.8/channels/sip/include/sip.h <span style=3D"color: grey">(=
373130)</span></li>
<li>/branches/1.8/configs/sip.conf.sample <span style=3D"color: grey">(373=
130)</span></li>
</ul>
<p><a href=3D"https://reviewboard.asterisk.org/r/2118/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6441695765259744928==--
More information about the asterisk-dev
mailing list