[asterisk-dev] [Code Review]: Enable support for early media in AMI originate action

[Olle E Johansson]

> On Sept. 30, 2011, 5:38 a.m., irroot wrote:
> > There a couple red blox otherwise looks good.

See above. I saw them first!!!


> On Sept. 30, 2011, 5:38 a.m., irroot wrote:
> > /trunk/main/pbx.c, lines 8796-8798
> > <https://reviewboard.asterisk.org/r/1472/diff/1/?file=20918#file20918line8796>
> >
> >     why not
> >     "channel % %s.\n", chan->name, (chan->_state == AST_STATE_UP) ? "was answered" : "got early media"
> >

Makes sense. Thanks for the review!


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1472/#review4463
-----------------------------------------------------------


On Sept. 29, 2011, 9:20 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1472/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2011, 9:20 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds support for early media in AMI action originate. Previously, we bridged at answer. In some cases when originating, you want to hear early media too, as important information might hide in there.
> 
> I saw the red dot first. I will kill it myself.
> 
> 
> This addresses bug ASTERISK-18644.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18644
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 338472 
>   /trunk/apps/app_originate.c 338472 
>   /trunk/include/asterisk/channel.h 338472 
>   /trunk/include/asterisk/pbx.h 338472 
>   /trunk/main/channel.c 338472 
>   /trunk/main/manager.c 338472 
>   /trunk/main/pbx.c 338472 
>   /trunk/pbx/pbx_spool.c 338472 
>   /trunk/res/res_clioriginate.c 338472 
> 
> Diff: https://reviewboard.asterisk.org/r/1472/diff
> 
> 
> Testing
> -------
> 
> Two weeks ago, we put the 1.4 version of this patch in production. The ladies placing calls are very happy now that they hear that the number they have dialed is not available.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110930/937fcdf8/attachment.htm>