[asterisk-dev] [Code Review]: Clean up asterisk.conf parsing

[Tilghman Lesher]

> On Sept. 23, 2011, 11:52 p.m., Tilghman Lesher wrote:
> > trunk/main/asterisk.c, line 2890
> > <https://reviewboard.asterisk.org/r/1462/diff/1/?file=20889#file20889line2890>
> >
> >     Since we don't ever pass CONFIG_FLAG_FILEUNCHANGED, this condition is impossible.
> 
> Paul Belanger wrote:
>     Why don't we pass it?  Trying to understand

Simple.  The reason for that flag is to enable short circuit logic when the file has not changed.  This file is never reloaded, so we never have a reason to pass that flag.


> On Sept. 23, 2011, 11:52 p.m., Tilghman Lesher wrote:
> > trunk/main/asterisk.c, lines 2912-2914
> > <https://reviewboard.asterisk.org/r/1462/diff/1/?file=20889#file20889line2912>
> >
> >     Looks like you've completely removed the WARNING message.  I think it should be restored here.
> 
> Paul Belanger wrote:
>     This was done because the other modules I have looked at, ones already cleaned up didn't do it.  I don't seen an issue adding it back, but if that is the case I'll also likely update the other modules with the same WARNING message.
>     
>     Warning on CONFIG_STATUS_FILEINVALID is not an issue, but users may choose not to use any configuration files for asterisk, which they have specifically done. Warning that the file is missing might be annoying everytime you start / restart asterisk.
>     
>     I think I'm going to create a wiki page so we can all hash out these comments / issue, then we can try to implement the same changes in the modules.

Why don't we do that on the mailing list instead?  The Wiki can document the final result of that, but the discussion should occur on the mailing list.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1462/#review4432
-----------------------------------------------------------


On Sept. 23, 2011, 9:39 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1462/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 9:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Last one for the day :D  This is pretty minor clean up of asterisk.conf
> 
> 
> Diffs
> -----
> 
>   trunk/main/asterisk.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1462/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110925/18fc614d/attachment-0001.htm>