[asterisk-dev] [Code Review]: Clean up asterisk.conf parsing

[Paul Belanger]

> On Sept. 24, 2011, 2:58 a.m., wdoekes wrote:
> > trunk/main/asterisk.c, line 2879
> > <https://reviewboard.asterisk.org/r/1462/diff/1/?file=20889#file20889line2879>
> >
> >     This should be a "const char *". Even though gcc doesn't complain, writing to config[0] will get you a segfault.

ACK'd


> On Sept. 24, 2011, 2:58 a.m., wdoekes wrote:
> > trunk/main/asterisk.c, line 2890
> > <https://reviewboard.asterisk.org/r/1462/diff/1/?file=20889#file20889line2890>
> >
> >     I would prefer an early error here. There are lots and lots of options (*) that aren't restored to their default in the new code here between FILEUNCANGED and FILEINVALID. If you leave it like it was, it is clearer that you cannot simply call the function again to get the same reload functionality as you can with the other files that do support reload.
> >     
> >     (*) ast_language_is_prefix, cfg_paths.system_name, option_maxfiles, to name only a few.

Right, this should be addressed.

I'm going to create a wiki page to document how things should work.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1462/#review4436
-----------------------------------------------------------


On Sept. 23, 2011, 9:39 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1462/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 9:39 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Last one for the day :D  This is pretty minor clean up of asterisk.conf
> 
> 
> Diffs
> -----
> 
>   trunk/main/asterisk.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1462/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/f3f41580/attachment.htm>