[asterisk-dev] [Code Review] New DUNDi cli commands to list cache entries

Paul Belanger reviewboard at asterisk.org
Thu Sep 22 08:56:36 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1438/#review4426
-----------------------------------------------------------


Seems the patch is missing the previous comment in the last review.  Not sure if they have been made yet, but they would still apply.


branches/10/pbx/pbx_dundi.c
<https://reviewboard.asterisk.org/r/1438/#comment8559>

    bypass = 1;



branches/10/pbx/pbx_dundi.c
<https://reviewboard.asterisk.org/r/1438/#comment8560>

    red blob since you are here



branches/10/pbx/pbx_dundi.c
<https://reviewboard.asterisk.org/r/1438/#comment8561>

    same


- Paul


On Sept. 22, 2011, 8:01 a.m., Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1438/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2011, 8:01 a.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Paul Belanger.
> 
> 
> Summary
> -------
> 
> This patch adds the following cli commands for DUNDi:
> 
> dundi show cache: List DUNDi cache entries
> dundi show hints: List DUNDi 'DONTASK' hints in the cache
> 
> 
> (Developer is Peter Racz from JIRA)
> 
> 
> This addresses bug ASTERISK-18390.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18390
> 
> 
> Diffs
> -----
> 
>   branches/10/pbx/pbx_dundi.c 337177 
> 
> Diff: https://reviewboard.asterisk.org/r/1438/diff
> 
> 
> Testing
> -------
> 
> I've tested this on my Asterisk 10 box, and the commands work as I would expect.
> 
> 
> Thanks,
> 
> Leif
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110922/4285d927/attachment.htm>


More information about the asterisk-dev mailing list