[asterisk-dev] [Code Review] Modify merge message so commit log message comes first.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1451/#review4421
-----------------------------------------------------------


This needs to be tested with a more substantial commit message that is more than a simple summary.  Also it needs to be tested with merging multiple revisions.


/svnmerge
<https://reviewboard.asterisk.org/r/1451/#comment8547>

    Is this line adding blank lines to the beginning of the commit message?



/svnmerge
<https://reviewboard.asterisk.org/r/1451/#comment8545>

    I don't think the Blocked revision line should be moved from the beginning.  This is the point of the commit.



/svnmerge
<https://reviewboard.asterisk.org/r/1451/#comment8546>

    I don't think the Unblocked revision line should be moved from the beginning.  This is the point of the commit.


- rmudgett


On Sept. 21, 2011, 4:33 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2011, 4:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Some discussion was made several weeks ago about modifying the svnmerge log message, such that the committer's log message comes first in any merge, followed by details on where the commit was originally made.  This improves our overall log messages.  Also, the URL is modified in the message as to show the public path, instead of the commit path, which is not available to most.
> 
> 
> Diffs
> -----
> 
>   /svnmerge 795 
> 
> Diff: https://reviewboard.asterisk.org/r/1451/diff
> 
> 
> Testing
> -------
> 
> Currently, an example message is as follows (after 2 merges):
> 
> -----start message-----
> 
> 
> More silly spacing changes
> 
> .....
> Merged revisions 337353 from http://svn.asterisk.org/svn/asterisk/branches/1.8
> 
> .....
> Merged revisions 337380 from http://svn.asterisk.org/svn/asterisk/branches/10
> -----end message-----
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110921/f68b2a6d/attachment-0001.htm>