No subject

security_event_get_transport()
security_event_encode_sin_local()
security_event_encode_sin_remote()
sip_report_invalid_peer()
sip_report_failed_acl()
sip_report_inval_password()
sip_report_auth_success()
sip_report_session_limit()
sip_report_failed_challenge_response()
sip_report_chal_sent
sip_report_inval_transport()
sip_report_security_event()

If you need any help making this change, let me know.</pre>
 </blockquote>





</blockquote>
<pre style=3D"margin-left: 1em; white-space: pre-wrap; white-space: -moz-pr=
e-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-=
word;">Sure... anything to help make the code maintainable.

I just took a stab at it.  This is a good learning experience and I am open=
 for help and suggestions.

Will upload the diff after publishing this comment.</pre>
<br />




<p>- elguero</p>


<br />
<p>On September 21st, 2011, 1:56 p.m., elguero wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('https://reviewboard.asterisk.org/media/r=
b/images/review_request_box_top_bg.png'); background-position: left top; ba=
ckground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By elguero.</div>


<p style=3D"color: grey;"><i>Updated Sept. 21, 2011, 1:56 p.m.</i></p>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Security Events Framework was added in 1.8 and support was a=
dded for AMI to generate events at that time.

This patch attempts to add support in chan_sip to generate security events.=
  Hopefully we can get this into Asterisk 10.

I am looking forward to hearing feedback on where this patch can be improve=
d especially from those who have an intimate knowledge of chan_sip.

Thanks</pre>
  </td>
 </tr>
</table>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Local dev machine and a softphone.  Generated events by usin=
g the wrong username, wrong password, wrong auth name, successful authentic=
ation.</pre>
  </td>
 </tr>
</table>



<div style=3D"margin-top: 1.5em;">
 <b style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href=3D"https://issues.asterisk.org/jira/browse/ASTERISK-18264">ASTERIS=
K-18264</a>


</div>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>/branches/10/CHANGES <span style=3D"color: grey">(337324)</span></li>

 <li>/branches/10/channels/chan_sip.c <span style=3D"color: grey">(337324)<=
/span></li>

 <li>/branches/10/channels/sip/include/security_events.h <span style=3D"col=
or: grey">(PRE-CREATION)</span></li>

 <li>/branches/10/channels/sip/include/sip.h <span style=3D"color: grey">(3=
37324)</span></li>

 <li>/branches/10/channels/sip/security_events.c <span style=3D"color: grey=
">(PRE-CREATION)</span></li>

 <li>/branches/10/configs/logger.conf.sample <span style=3D"color: grey">(3=
37324)</span></li>

 <li>/branches/10/include/asterisk/event_defs.h <span style=3D"color: grey"=
>(337324)</span></li>

 <li>/branches/10/include/asterisk/security_events_defs.h <span style=3D"co=
lor: grey">(337324)</span></li>

 <li>/branches/10/main/event.c <span style=3D"color: grey">(337324)</span><=
/li>

 <li>/branches/10/main/security_events.c <span style=3D"color: grey">(33732=
4)</span></li>

</ul>

<p><a href=3D"https://reviewboard.asterisk.org/r/1362/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============1184309205557929732==--