[asterisk-dev] [Code Review] Set Write format if it does not match native format or current write format.

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1442/
-----------------------------------------------------------

(Updated Sept. 21, 2011, 2:26 a.m.)


Review request for Asterisk Developers.


Changes
-------

Reworked this as its only needed if rawformat is not capable and checks the format prior to translation.

If there no objections ill be commiting this latter.


Summary
-------

Its possible to loose audio on ast_write when the channel is not transcoded correctly.

in the case of DAHDI the channel is hungup.

a simple check and fix solves this problem.

Many support issues are open over this issue.


This addresses bugs ASTERISK-14384, ASTERISK-17502, ASTERISK-17541, ASTERISK-18063, ASTERISK-18325, and ASTERISK-18422.
    https://issues.asterisk.org/jira/browse/ASTERISK-14384
    https://issues.asterisk.org/jira/browse/ASTERISK-17502
    https://issues.asterisk.org/jira/browse/ASTERISK-17541
    https://issues.asterisk.org/jira/browse/ASTERISK-18063
    https://issues.asterisk.org/jira/browse/ASTERISK-18325
    https://issues.asterisk.org/jira/browse/ASTERISK-18422


Diffs (updated)
-----

  /branches/1.8/main/channel.c 337177 

Diff: https://reviewboard.asterisk.org/r/1442/diff


Testing
-------

This patch has been in use by me in production for a long period and has resolved these issues and works as expected.


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110921/cc7ac42a/attachment.htm>